Re: [PATCH] Record SBuf and MemBlob sizes at destruct time

On 24/11/2013 8:05 p.m., Kinkie wrote:
> On Sun, Nov 24, 2013 at 12:16 AM, Amos Jeffries wrote:
>> On 24/11/2013 9:29 a.m., Kinkie wrote:
>>> Hi,
>>> the attached patch records (and displays in cachemgr) the histogram
>>> of the sizes of SBufs and MemBlobs.
>>>
>>> Builds and runs, but since SBuf is not yet used, no meaningful output
>>> can be obtained.
>>> The code lives as lp:~squid/squid/stringng (together with other not
>>> yet merged SBuf bits, this is a cherrypick).
>>>
>>
>>
>> in src/SBufDetailedStats.cc
>> * please name the namespace
>
> What is the benefit? The code in there is just in order to have the
> post-init stuff done in StatHist, it's not meant to be seen anywhere
> else (so the anonymous namespace is really intentional). Not a big
> deal, but I'm curious.

It will save on getting doxygen confused. And if we ever need to
reference inside that scope or add bits to it the namespace name
provides a hint as to what might be appropriate use.

Amos
Received on Sun Nov 24 2013 - 09:01:50 MST