Re: [PATCH] Record SBuf and MemBlob sizes at destruct time

On Sun, Nov 24, 2013 at 12:16 AM, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
> On 24/11/2013 9:29 a.m., Kinkie wrote:
>> Hi,
>> the attached patch records (and displays in cachemgr) the histogram
>> of the sizes of SBufs and MemBlobs.
>>
>> Builds and runs, but since SBuf is not yet used, no meaningful output
>> can be obtained.
>> The code lives as lp:~squid/squid/stringng (together with other not
>> yet merged SBuf bits, this is a cherrypick).
>>
>
>
> in src/SBufDetailedStats.cc
> * please name the namespace

What is the benefit? The code in there is just in order to have the
post-init stuff done in StatHist, it's not meant to be seen anywhere
else (so the anonymous namespace is really intentional). Not a big
deal, but I'm curious.

> in src/SBufDetailedStats.h
> * please add an empty line between code lines and each following comment.
> - same in src/StatHist.h

Done, also for non-owned code.

> * please make use of #ifndef safety wrappers

Duh!

> in src/SBufStatsAction.cc
> * please move the warning text up to the top of the report.
> - I know its not part of this patch, but as you are altering it anyway...

Sure.

Ok, all done except for the namespace at lp:~squid/squid/stringng

-- 
    /kinkie