Re: [PATCH] Record SBuf and MemBlob sizes at destruct time

From: Kinkie <gkinkie_at_gmail.com>
Date: Sun, 24 Nov 2013 10:26:28 +0100

>>> in src/SBufDetailedStats.cc
>>> * please name the namespace
>>
>> What is the benefit? The code in there is just in order to have the
>> post-init stuff done in StatHist, it's not meant to be seen anywhere
>> else (so the anonymous namespace is really intentional). Not a big
>> deal, but I'm curious.
>
> It will save on getting doxygen confused. And if we ever need to
> reference inside that scope or add bits to it the namespace name
> provides a hint as to what might be appropriate use.

Ok, fair enough. I will add a name to it.
Once that's done, may I submit?
(btw: that post-init code is the result of StatHist C-ness, it should
go away, I'd vebture by subclassing and polymorphism)

Thanks

-- 
    /kinkie
Received on Sun Nov 24 2013 - 09:26:36 MST

This archive was generated by hypermail 2.2.0 : Sun Nov 24 2013 - 12:00:09 MST