Re: [PATCH] More CharacterSet

From: Kinkie <gkinkie_at_gmail.com>
Date: Sun, 5 Jan 2014 22:59:32 +0100

> in src/base/CharacterSet.cc
>
> * We should avoid defining CharacterSet::CRLF since that is a specific
> ordered pattern rather than unordered set of characters.
>
> * Please add an extra comment noting why QDTEXT and OBSTEXT are elided ...
> because they require C++11 constructors.
>
> +1 once those are fixed.

Fixed and merged.

Thanks.

-- 
    /kinkie

Received on Sun Jan 05 2014 - 21:59:40 MST

This message: [ Message body ]
Next message: Amos Jeffries: "Re: [PATCH] HTTP Parser upgrade"
Previous message: Amos Jeffries: "Re: [PATCH] More CharacterSet"
In reply to: Amos Jeffries: "Re: [PATCH] More CharacterSet"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]

This archive was generated by hypermail 2.2.0 : Mon Jan 06 2014 - 12:00:10 MST