On 2014-01-06 04:25, Kinkie wrote:
> Hi,
> the attached patch expands on the already-merged CharacterSet,
> adding:
> - operator+
> - addRange
> - range-based constructor
> - a number of predefined sets, mostly taken from the HTTP specs
> - unit test
>
> It's a candidate for merging to trunk.
in src/base/CharacterSet.cc
* We should avoid defining CharacterSet::CRLF since that is a specific
ordered pattern rather than unordered set of characters.
* Please add an extra comment noting why QDTEXT and OBSTEXT are elided
... because they require C++11 constructors.
+1 once those are fixed.
Amos
Received on Sun Jan 05 2014 - 20:50:37 MST
This archive was generated by hypermail 2.2.0 : Mon Jan 06 2014 - 12:00:10 MST