Re: cvs commit: squid/src cf.data.pre wccp2.c

On 17/05/2006 3:55 a.m., hno@squid-cache.org wrote:
> hno 2006/05/16 09:55:45 MDT
>
> Modified files:
> src cf.data.pre wccp2.c
> Log:
> WCCP2 cleanup
>
> * wccp2_router defaults to none (not 0.0.0.0:2048). It's a list so it can
> be empty.
>
> * Internal functions made static to keep gcc happy
>
> Revision Changes Path
> 1.309 +3 -3 squid/src/cf.data.pre
> 1.2 +6 -9 squid/src/wccp2.c
>

I've just found a minor bug related to this. By specifying in my squid.conf:

wccp2_router 192.168.0.1

then I get no debugging, no wccp2 functionality, and no warning that the syntax
is incorrect (bungled?). Unfortunately the documentation example in squid.conf
doesn't state that a port number is required. (Although the README.wccpv2 does,
but we can't assume that everyone will go looking for it in /doc).

I suggest that if no port is specified, we default to 2048, the same as WCCPv1,
or else I guess I can write a patch to fix the documentation.

reuben
Received on Thu May 18 2006 - 20:05:34 MDT