Re: acl and cache

Probably, but not yet sure the fix is the appropriate one.

Goal: make no_cache NOT purge existing cached objects, only bypass the
cache.

Regards
Henrik

lör 2006-05-13 klockan 11:23 +0800 skrev Adrian Chadd:
> Is this something outstanding that should be fixed in squid-2.5/squid-3?
>
> I'll merge in the squid-2.5 changes into my local branch and let everyone
> know if there are any issues.
>
>
> Adrian
>
> ----- Forwarded message from Henrik Nordstrom <henrik@henriknordstrom.net> -----
>
> From: Henrik Nordstrom <henrik@henriknordstrom.net>
> To: Aur?lien Bras <aurelien.bras@gmail.com>
> Cc: squid-users@squid-cache.org
> Date: Thu, 04 May 2006 16:33:22 +0200
> X-Mailer: Evolution 2.6.1 (2.6.1-1.fc5.2)
> Subject: Re: [squid-users] acl and cache
>
> tor 2006-05-04 klockan 14:35 +0200 skrev Aur??lien Bras:
>
> > No cache is purged
>
> Right.
>
> Try the attached patch.
>
> Regards
> Henrik
>
> ? build.log
> ? signfile.sh
> ? contrib/.squid.rc.swp
> Index: src/http.c
> ===================================================================
> RCS file: /cvsroot/squid/squid/src/http.c,v
> retrieving revision 1.384.2.34
> diff -u -p -r1.384.2.34 http.c
> --- src/http.c 18 Oct 2005 15:09:56 -0000 1.384.2.34
> +++ src/http.c 4 May 2006 14:32:34 -0000
> @@ -457,7 +457,7 @@ httpProcessReplyHeader(HttpStateData * h
> storeTimestampsSet(entry);
> /* Check if object is cacheable or not based on reply code */
> debug(11, 3) ("httpProcessReplyHeader: HTTP CODE: %d\n", reply->sline.status);
> - if (neighbors_do_private_keys)
> + if (neighbors_do_private_keys && httpState->orig_request.flags.cachable)
> httpMaybeRemovePublic(entry, reply->sline.status);
> if (httpHeaderHas(&reply->header, HDR_VARY)
> #if X_ACCELERATOR_VARY
>
>
>
>
> ----- End forwarded message -----