On 05/13/2014 02:45 AM, Steve Hill wrote:
> On 12.05.14 18:20, Alex Rousskov wrote:
>> The Token class in v3.4 uses an ugly union (instead of "struct") for the
>> data member. Thus, data.timespec should be identical to data.string. The
>> fact that changing .timespec to .string makes a difference indicates
>> that something else is probably broken.
> Ok, I hadn't spotted that. On closer inspection, in 3.4.4 it is a
> union, but 3.4.5 changes it to a struct
Sorry, I apparently used stale v3.4 branch code. You are right: Trunk
and v3.4.5 code/problems are the same in this area.
> In any case, I don't see any reason for having both "timespec" and
> "string" since they are both the same thing, so I think removing
> timespec is still probably the right thing to do for the sake of
> readability.
I am not an expert in this code area, but I agree: Your fix should be
committed to both trunk and v3.4 branch IMO.
Thank you,
Alex.
Received on Tue May 13 2014 - 15:37:57 MDT
This archive was generated by hypermail 2.2.0 : Tue May 13 2014 - 12:00:13 MDT