Re: [MERGE] Squid Patch (revision 10487)

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Tue, 13 May 2014 03:52:49 +1200

On 13/05/2014 2:25 a.m., Michael Pye wrote:
> On 2014-05-11 18:40, Amos Jeffries wrote:
>> Not as yet. Henrik pointed out a problem that needed testing:
>> http://www.squid-cache.org/mail-archive/squid-dev/201005/0156.html
>>
>> I dont think we send only-if-cached any longer.
>>
>> Can you confirm that, or answer Henriks question?
>
> Sorry - I can't confirm that, I don't know the internals well enough for
> that.

The check is whether the HTTP requests sent to siblings contain
Cache-Control:only-if-cached. Or if things break when the client sends
that header.

>
> I am still interested in getting this patch to be either included or
> tested however. If I can help on testing this please let me know.
>
> I have compiled a version with the patch on squid 3.4.5 and it appears
> to do what we want, however it seems to have a bug. When a stale object
> needs updating, it does query the sibling, and if it has a fresher copy
> it is returned. If however the sibling does not have a fresher copy the
> original squid queries the origin, but seems to keep the "Age:" header
> from the last stale request, so although it has updated the object it
> will expire quicker than it should as it has an incorrectly calculated
> "Age:" header on it. I assume this is due to the patch introducing
> something new that is not being considered when refreshing from a
> sibling. Anyone interested in helping on this ?

Here is the guts of the original patch as should be relevant to
Squid-3.5 (or 3.4).
http://master.squid-cache.org/~amosjeffries/patches/Pye_s35.patch

Cheers
Amos
Received on Mon May 12 2014 - 15:52:55 MDT

This archive was generated by hypermail 2.2.0 : Mon May 12 2014 - 12:00:13 MDT