Re: Announcing new external_acl helper: delayer

Looks good. However ...

On 12/05/2014 7:19 a.m., Kinkie wrote:
> === added directory 'helpers/external_acl/delayer'
> === added file 'helpers/external_acl/delayer/Makefile.am'
> --- helpers/external_acl/delayer/Makefile.am 1970-01-01 00:00:00 +0000
> +++ helpers/external_acl/delayer/Makefile.am 2014-05-11 19:12:35 +0000
> @@ -0,0 +1,12 @@
> +include $(top_srcdir)/src/Common.am
> +
> +libexec_SCRIPTS = delayer
> +CLEANFILES += delayer delayer.8
> +man_MANS = delayer.8
> +EXTRA_DIST = delayer.pl.in delayer.8 required.m4
> +
> +delayer.8: delayer
> + pod2man delayer delayer.8
> +
> +delayer: delayer.pl.in
> + $(subst_perlshell)

... under the helper naming convention these should be installed as
ext_delayer_acl and ext_delayer_acl.8

 I have also taken up naming the .pl.in with same name as the installed
script. But that it optional.

+1 with that change.

Amos
Received on Mon May 12 2014 - 04:46:49 MDT