Re: /bzr/squid3/trunk/ r13384: Bug 1961: pt1: URL handling redesign

On 3/05/2014 11:39 a.m., Alex Rousskov wrote:
> On 05/02/2014 11:26 AM, Tsantilas Christos wrote:
>
>> Looks that the attached patch should be enough to solve trunk with ecap
>> build.
>> If no problem I will apply to trunk.
>
> Looks good to me. This should close item #3 on the to-do list, and Amos
> has made great progress with #1 already.
>

+1 from me as well.

Amos

>
> Thank you,
>
> Alex.
>
>
>> 1. If Squid trunk does not set HttpMsg::http_ver [correctly] when
>> parsing any requests or responses, we should fix the corresponding Squid
>> code. This will ensure that eCAP adapters are getting the right
>> information about virgin messages. This item requires an investigation
>> and may not require any code changes.
>>
>> 2. If Squid trunk does not use HttpMsg::http_ver [correctly] when
>> formatting any requests or responses, we should fix the corresponding
>> Squid code. This will ensure that eCAP adapters can adapt virgin
>> messages as needed. Note that Squid does not support post-cache
>> vectoring points so Squid should still set its own http_ver in any
>> outgoing messages. This item requires an investigation and may not
>> require any code changes.
>>
>> 3. Squid eCAP implementation should be changed to read and write
>> HttpMsg::http_ver. This affects two
>> Adaptation::Ecap::FirstLineRep::protocol methods and possibly other
>> code. This item requires code changes.
>
>
Received on Sat May 03 2014 - 10:09:09 MDT