Re: [PATCH] Ssl::PeerConnector class

On 04/22/2014 10:18 PM, Amos Jeffries wrote:
>
> Hi Christos,
> Alex and I have just reached a design agreement about how to manage
> these modularizations going forward.

Hi Amos,

>
> We have decided to construct a namespace Security:: in a library at
> security/libsecurity.la which presents the polished neutral API for
> accessing SSL features. Leaving the code presenting OpenSSL specific API
> in ssl/*
>
> Since this class is already presenting a neutral API. Would you be able
> to make this the first code moved to the new namespace Security::
> (instead of Ssl::)?

I will move it under the Security:: namespace if needed.
Does the Security namespace refers to SSL connections? Will it be a
layer to support multiple SSL libraries?

In this patch, the PeerConnector has dependencies to OpenSSL library. I
do not know if it can be considered as an independent part.
However removes the openSSL related code from FwdState.cc file.

Should the PeerConnector.* files moved under a new "security/" folder?

>
> +1 for commit regardless of whether you choose to accept this request.
>
> Thank you.
> Amos
>
>
Received on Wed Apr 23 2014 - 10:42:07 MDT