Re: [PATCH] refactor Vector

On Mon, Feb 10, 2014 at 5:16 PM, Alex Rousskov
<rousskov_at_measurement-factory.com> wrote:
> On 02/10/2014 02:20 AM, Kinkie wrote:
>>> The kind of cast appears to be wrong here: Const_cast<> is normally used
>>> to remove const, not add it. It is not used to change the type.
>>
>> It is currently a c-style cast.
>> Attributes is built over push_back(), so the only way to cleanly make
>> it const would be to copy it after it's built.
>> Without it,
>> CustomParser.cc:209:83: error: invalid conversion from 'char**' to
>> 'const char**' [-fpermissive]
>
> My bad: I did not realize the type before casting is char**.
> Const_cast<> is the right thing to do here.

NP :)
Merged to trunk, now moving on to refactoring Vector->std::vector

-- 
    Francesco