Re: [PATCH] Coverity defect 1135443

From: Kinkie <gkinkie_at_gmail.com>
Date: Fri, 10 Jan 2014 16:54:00 +0100

done.

On Fri, Jan 10, 2014 at 12:53 AM, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
> On 9/01/2014 9:57 p.m., Kinkie wrote:
>> Hi,
>> Coverity detected a possible division by zero in
>> src/format/Format.cc line 500, on a Token->divisor.
>> The defect is a false positive as that value is correctly initialized,
>> but it could be a chance to document as a class invariant that that
>> value must not be zero, and initialize it to 1 in the default
>> constructor.
>> Attached patch does just that.
>>
>>
>>
>
> +1. Please apply.
>
> Amos

-- 
    /kinkie
Received on Fri Jan 10 2014 - 15:54:13 MST

This archive was generated by hypermail 2.2.0 : Fri Jan 10 2014 - 12:00:12 MST