Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

Patch applied to trunk

On 12/05/2013 03:14 PM, Tsantilas Christos wrote:
> If there are no any objections I will apply this patch to trunk...
>
> On 11/25/2013 12:01 PM, Tsantilas Christos wrote:
>> This is the third version of the patch
>>
>> On 11/23/2013 08:08 AM, Amos Jeffries wrote:
>>> On 23/11/2013 5:42 a.m., Tsantilas Christos wrote:
>>>> I am sending a new patch which I hope meets the requirements.
>>>>
>>>> It supports only one %key_extras authentication scheme parameter. This
>>>> is just append to the current request line format.
>>>
>>>
>>> Thank you. Looks much better.
>>>
>>>
>>> in src/auth/Config.cc:
>>>
>>> * Auth::Config::parse
>>> - please make "key_extras" case-sensitive lower case.
>>> - several debugs with HERE macro. Please try to avoid that.
>>
>> Fixed in this patch
>>
>>>
>>> - missing debugs before first use of self_destruct() when
>>> !nlf->parse(keyExtrasLine.termedBuf(). The parser only outputs a
>>> warning, if we are going to call self_destruct we need to output a FATAL
>>> with reason why the simple warning event is killing Squid.
>>
>> fixed
>>
>>>
>>> - debugs before second self_destruct() is missing "FATAL:" prefix.
>>
>> fixed
>>
>>>
>>>
>>> in src/cf.data.pre
>>>
>>> * you define key_extras in a section of parameters common to all auth
>>> schemes. No need to re-define it in the section per-scheme.
>>
>> I removed the key_extras from auth schemes sections.
>>
>>>
>>> Amos
>>>
>>>
>>
>
>
Received on Fri Dec 06 2013 - 15:01:03 MST