Re: [PATCH] SBufList

Hi,
  v2 attached, fixing these issues.

On Tue, Nov 26, 2013 at 2:11 AM, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
> On 26/11/2013 11:40 a.m., Kinkie wrote:
>> Hi,
>> attached is v1 of SBufList. Its purpose is to be the eventual heir
>> to wordlist. For this reason I've implemented the bare minimum API to
>> cover wordlist's API, and kept code to a minimum by making it a
>> typedef of std::list.
>>
>> The patch is missing Makefile.am integration, it's a cherrypick of
>> lp:~squid/squid/stringng. I'll hand-merge Makefile.am if the code is
>> accepted.
>>
>> The only remaining bit of that branch is the tokenizer. As Alex
>> mentioned he's going to draft an API for that, it's quite likely that
>> if the two patches I'm proposing today and Amos' SBuf-based String
>> reimplementation are accepted, then this branch can (finally) be
>> closed, and the chase can begin for having clients use StringNG.
>>
>> Thanks,
>>
>
>
> in src/SBufList.cc:
> * copyright blurb
>
> * isMember() has a few issues:
> - please put return type on its own line consistent with the squid
> coding style guidelines
>
> in src/SBufList.h:
> * copyright blurb
>
> * please use a predefine "class wordlist;" instead of including wordlist.h
>
>
> Amos
>

-- 
    /kinkie