Re: [PATCH] Add auth_param request_format, request_realm to proxy authentication schemes

On 20/11/2013 12:49 p.m., Alex Rousskov wrote:
> On 11/19/2013 04:01 PM, Amos Jeffries wrote:
<snip>

>> If you want to omit it from this patch and do it as a second one that
>> would be okay.
>
> I do not like the idea of increasing the amount of work further by
> splitting this feature into two. I think your choices are:
>
> 1) Allow %credentials to be used internally in the key_extras patch.
> This is less work for Christos (because the code is already written) and
> adds a potentially useful feature to Squid.

This one I think.
 If you mean leaving the %credentials in as a log option which may be
used inside the key_extras format code.

If you mean using it as the way to build the existing prefix portion of
the submitted helper line, no. For the reason that the log line
processing has quoting and encoding logics that will need to be avoided
- lets reduce the work policing that.

Amos
Received on Wed Nov 20 2013 - 02:46:41 MST