Re: stringng-cherrypick r12764

From: Kinkie <gkinkie_at_gmail.com>
Date: Fri, 27 Sep 2013 12:06:37 +0200

>> How about proceeding like this: merge as-is and trust the callers to
>> know what they're doing, so that I can spend some time on implementing
>> these flags? It'll be tedious work, but it shouldn't require too much
>> brainpower. The alternative (blocking StringNG until the conversions
>> work is done) would stall StringNg even more :(
>
>
> I would go with trusting the callers for now.

Yay! This means that all is left to do is:
- addressing your concenr about importing NULLs
- removing copyright assignments (at least until a guideline is
defined; if the decision will be to keep them they can always be added
later)
- removing the negative-offset test-cases in the unit tests

and then we should be ready for merge, right?
(we're still missing some bits after this: tokenizer, cachemgr
integration and some utilities, but these haven't been reviewed yet)

-- 
    /kinkie
Received on Fri Sep 27 2013 - 10:06:58 MDT

This archive was generated by hypermail 2.2.0 : Fri Sep 27 2013 - 12:00:11 MDT