Re: [PATCH] Unknown cfg function

On 07/30/2013 08:12 PM, Amos Jeffries wrote:
> I just ran your patch past my set of test cases built from the user
> complaints so far:
>
>
> 2013/07/31 04:56:39| Processing: configuration_includes_quoted_values off
> ...
> 2013/07/31 04:56:39| Processing: acl notAfunction url_regex
> ^somethingOLD(.*)
> 2013/07/31 04:56:39| Processing: acl notAmacro url_regex "somethingOLD$"
> 2013/07/31 04:56:39| Unsupported cfg macro: $"
> FATAL: Bungled (#2) strings.conf line 23: acl notAmacro url_regex
> "somethingOLD$"
>

Use single quotes. The single quotes does not try to interpret the '$'
character

The "configuration_includes_quoted_values" does not disables the macros
in quotes.
It justs control the quotes behavior for some configuration parameters.
The quotes for some alcs for example means read from file. It
disables/enables this behavior.

However we can extend its behavior.

>
>
> Of somewhat less importance there is also this weird case showing up
> when I create a bungled http_access line using parameters() in the OFF
> mode.
> This one is not specific to your patch, it happens with mine too, but it
> does worry me...
>
> 2013/07/31 04:56:39| Processing: configuration_includes_quoted_values off
> ...
> 2013/07/31 05:00:41| Processing: http_access parameters("foo")
> 2013/07/31 05:00:41| aclParseAccessLine: strings.conf line 18:
> http_access parameters("foo")
> 2013/07/31 05:00:41| aclParseAccessLine: Access line contains no ACL's,
> skipping

Which is the problem here? Does the foo file has any values?

> 2013/07/31 05:00:41| Processing: acl notAfunction url_regex
> ^somethingOLD(.*)
> 2013/07/31 05:00:41| FATAL: Invalid ACL type 'notAfunction' for ACL
> named all
> FATAL: Bungled (#2) strings.conf line 21: acl notAfunction url_regex
> ^somethingOLD(.*)
>

If I use the following:
configuration_includes_quoted_values off
acl notAfunction url_regex ^somethingOLD(.*)
configuration_includes_quoted_values on

I am not getting any parse error...
Are you sure you are not have any
"configuration_includes_quoted_values on"
line?

>
> Amos
>
>
Received on Tue Jul 30 2013 - 18:23:27 MDT