Re: [PATCH] Copy external ACL username and password attributes in HttpRequest::inheritProperties for logging

On 12/07/2013 2:18 p.m., Nathan Hoad wrote:
> When a request is successfully adapted, the external ACL username and
> password are now inherited with this patch. This means the
> LFT_USER_NAME log token can display the username from an external ACL
> if available, for adapted requests.
>
> The HttpRequest will inherit the password for good measure as well -
> while none too useful, it seems strange to inherit the username but
> not the password.
>
> --
> Nathan Hoad
> Software Developer
> www.getoffmalawn.com

This is yet another probem with how Adaptation is using the
inheritProperties() and clone() methods of HttpRequest. Those fields are
already copied over in clone() and need to be removed from there if they
are added to inheritProperties().

Amos
Received on Fri Jul 12 2013 - 08:57:07 MDT