Re: [PATCH] reload into If-None-Match

I will commit this patch to trunk if there is not any objection....

On 06/29/2013 07:28 AM, Amos Jeffries wrote:
> On 29/06/2013 1:50 a.m., Tsantilas Christos wrote:
>> This patch sends an If-None-Match request, when we need to re-validate
>> if a cached object which has a strong ETag is still valid.
>>
>> This is also done in the cases an HTTP client request contains HTTP
>> headers prohibiting a from-cache response (i.e., a "reload" request).
>> The use of If-None-Match request in this context violates RFC 2616 and
>> requires using reload-into-ims option within refresh_pattern squid.conf
>> directive.
>>
>> The exact definition of a "reload request" and the adjustment/removal of
>> "reload" headers is the same as currently used for reload-into-ims
>> option support. This patch is not modifying that code/logic, just adding
>> an If-None-Match header in addition to the IMS header that Squid already
>> adds.
>>
>> This is a Measurement Factory Project
>
> +1. Looks okay to me.
>
> The comment "Previous reply didn't have a Last-Modified header..." in
> chunk ~547 is now outdated you need to mention ETag in there as well.
> That can be fixed on commit without another review.
>
> Amos
>
Received on Mon Jul 08 2013 - 20:04:11 MDT