Re: /bzr/squid3/trunk/ r12817: Log an ERROR instead of halting on unknown cache_dir types

On 05/14/2013 09:31 AM, Amos Jeffries wrote:
> ------------------------------------------------------------
> revno: 12817

> Log an ERROR instead of halting on unknown cache_dir types
>
> Squid-3 can run fine without any configured cache_dir. This assists with
> upgrade from older Squid-2 where COSS or NULL cache types may be present.
> It also assists with backward compatibility for any future cache types
> which may be added in future.

> modified:
> src/cache_cf.cc

FWIW, I think Squid should refuse to start when misconfigured. Just
because Squid "can work" without a directive, does not imply that the
directive is not essential in a given setup. And problems with Squid not
starting are usually much more visible to the admins than problems with
Squid running misconfigured. Moreover, problems with Squid not starting
are often less visible to users as a non-running Squid is going to be
bypassed!

Ignoring COSS cache_dirs does not assist with upgrade. The upgrade goal
is to make Squid work better than it used to. Ignoring a cache_dir is
unlikely to fulfill that goal unless Squid was misconfigured before the
upgrade (i.e., was using a cache_dir that was not really needed).

Ignoring "null" cache_dir is OK, but should be done differently and is
probably not worth the extra code.

$0.02,

Alex.
Received on Tue May 14 2013 - 16:26:08 MDT