Re: [PATCH] Bug 3389: Auto-reconnect for tcp access_log

On 05/11/2013 09:11 PM, Amos Jeffries wrote:
> On 12/05/2013 8:59 a.m., Alex Rousskov wrote:
>> On 05/11/2013 12:36 AM, Amos Jeffries wrote:

>>> * please remove the XXX commenat about Open().
>> Done. Although the XXX was correct IMO: It is wrong to expose the
>> callers to all the TcpLogger details when all they need is one
>> TCP-agnostic function call.

> That function was already the only public one in the class, therefore it
> seems the XXX todo entry was already implemented.

From public class API point of view, yes. From whole class point of
view, no: There is no need for the caller to know that the TcpLogger
class itself exists. However, this is a very minor design problem, of
course.

Cheers,

Alex.
Received on Mon May 13 2013 - 13:55:30 MDT