Re: [PATCH] Bug 3389: Auto-reconnect for tcp access_log

Hello,

    The attached r12778 patch contains all current cumulative changes
for bug 3389. Please see that patch preamble for technical details. They
have not changed since the last submission. These changes correspond to
the following lp branch (at revision 12778):
https://code.launchpad.net/~squid/squid/bug3389

The attached c12778 patch contains just the changes since the previous
cumulative patch was posted:

* Protected direct TcpLogger calls (via Logfile API) with cbdata.

* Polished TcpLogger class description.

* Moved Logfile c-style call wrappers from ModTcp to static TcpLogger
methods, removing ModTcp.{cc,h}.

* Placed TcpLogger inside the Log namespace.

The last two changes address the following Amos review comments:

On 04/15/2013 09:33 PM, Amos Jeffries wrote:
> 2) splitting the active code from ModTcp.* files into TcpLogger.*
> AsyncJob but leaving ModTcp.* as a wrapper is a very nasty way to do it.
> The log/File.h API definition uses static function pointers, which *do
> not* need to be the ones currently in ModTcp.* - that was simply for
> consistency in the C-style code.
> Please either call the AsyncJob Log::ModTcp and leave it in the
> original files, OR remove the ModTcp.* wrappers entirely - replacing
> with TcpLogger static members.
> Either way new objects need to be in the Log:: namespace now.

The other review comment regarding making logformat option optional is
not addressed because there is currently no consensus regarding those
changes. However, r12778 code should process ACLs in new access_log
style correctly (I posted a patch fixing that bug earlier).

HTH,

Alex.