Re: [PATCH] variant Key negotiation on error pages

On 21/03/2013 3:09 p.m., Amos Jeffries wrote:
> On 21/03/2013 1:34 p.m., Alex Rousskov wrote:
>> On 03/20/2013 05:40 PM, Amos Jeffries wrote:
>>> The Key: header being proposed for standardization replaces and extends
>>> the Vary header to provide more fine-grained variant selection by
>>> caches.
>>>
>>> The attached patch add the Key: header on Squid generated error
>>> pages so
>>> that any receiving clients which support the new header are able to use
>>> it for handling our error pages.
>>>
>>> This also serves as a implementation example for how origin servers can
>>> easily implement Key headers alongside Vary headers during the upgrade
>>> transition period.
>>> see http://tools.ietf.org/html/draft-fielding-http-key-02 for the
>>> current specification.
>>
>>> + // Key:Accept-Language;b="foo"
>>> + tmp.append(";b=\"");
>>> + tmp.append(err_language);
>>> + tmp.append('"');
>>
>> This will assert when err_language is nil (which happens to be the case
>> in the build I just tested).

"Doh!" seems to be the word. Revised patch attached.

Amos