Re: [PATCH] support parameters for no-cache and private

On 02/19/2013 06:12 PM, Alex Rousskov wrote:
> On 02/16/2013 06:51 PM, Amos Jeffries wrote:
>> Please run this past Co-Advisor to confirm the private="..." and
>> no-cache="..." cases are now all "Precondition Failed".
>
> FYI: Co-Advisor crashes current Squid trunk ("Received Segment
> Violation...dying.") so we will need to triage and fix that before we
> can test the CC changes. This may take a few days.

Hi Amos,

    I think I know where the problem is. For all responses without a CC
header, the cache_control member is nil in the following patch code
dereferencing it:

> === modified file 'src/http.cc'
> --- src/http.cc 2013-02-16 11:42:53 +0000
> +++ src/http.cc 2013-02-17 01:41:03 +0000
> @@ -362,6 +362,16 @@
> }
>
> // NP: request CC:no-cache only means cache READ is forbidden. STORE is permitted.
> + if (rep->cache_control->hasNoCache() && rep->cache_control->noCache().defined()) {

Please fix.

Thank you,

Alex.
Received on Wed Feb 20 2013 - 20:52:16 MST