Re: [PATCH] HelperReply upgrade stage 2

On 11/22/2012 10:28 PM, Amos Jeffries wrote:
> On 11/11/2012 6:28 p.m., Amos Jeffries wrote:
>> Updated patch attache, containing the updates below...
>>
>
> If there is no objections I will commit this to trunk soon. It has
> passed 10+ days with no additional followup.

FYI: Your last response indicated that more changes would follow so the
ball was on your side, not the reviewers side:

>>>>>> The response syntax for all helpers becomes:
>>>>>> [channel-ID SP ] result [ SP key-pair ... ] [ SP other] EOL
>>>>>> + * line := [ result ] *#( key-pair )
>>>>> There is such a thing as "key:value pair", but "key-pair" does not
>>>>> make
>>>>> sense to me. I suggest replacing "key-pair" with "key=value" or
>>>>> "note".
>>>>> The latter would need to be spelled out separately, of course.
>>>> Would kv-pair, the other way of writing it be more familiar?
>>> Yes, I think "kv-pair" would be better (and it appears to be more widely
>>> used than "key-pair", which is usually found in "a pair of public and
>>> private keys" context. "Key-value pair" appears to be "standard" for our
>>> context, even with its own wikipedia entry.
>>>
>>
>> Okay will do.

Alex.
Received on Mon Nov 26 2012 - 16:36:48 MST