On 11/18/2012 10:28 PM, Amos Jeffries wrote:
> Inspired by bug 3663 - does not fix it, but then I'm not sure the report
> is a squid bug or if it is regular filesystem permissions error.
>
> This patch seeks to improve the messages output by UFS swap log
> management. It also includes a small local variable symbol change from
> "new_path" to "from_path" to prevent future developer mistakes like the
> one seen in bug 3663 (mistaking "new_path" for the new destination path
> of xrename() ).
Looks good to me. I would probably call that temporary path variable
tmp_path, but this is not a big deal because your new comments explain
what happens.
Thank you,
Alex.
Received on Mon Nov 19 2012 - 17:43:46 MST
This archive was generated by hypermail 2.2.0 : Fri Nov 30 2012 - 12:00:18 MST