Re: /bzr/squid3/trunk/ r12247: Revert r12231 - seems to break SMP cache

On 4/08/2012 8:59 a.m., Alex Rousskov wrote:
> On 08/01/2012 05:54 AM, Amos Jeffries wrote:
>> ------------------------------------------------------------
>> revno: 12247
>> committer: Amos Jeffries <squid3_at_treenet.co.nz>
>> branch nick: trunk
>> timestamp: Wed 2012-08-01 23:54:23 +1200
>> message:
>> Revert r12231 - seems to break SMP cache
>> modified:
>> src/store_dir.cc
> Is there a bug report or a mailing list posting related to this
> reversal? The r12231 change was fixing a bug. It is possible that the
> fix exposed other bugs, of course, but it is difficult for me to fix
> those if I do not know what they are. If feels that such a drastic
> action as a reversal deserves at least a little bit more documentation.

The point of breakage can be found here:
http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/1971/console

I tested before reversion and confirmed it was that particular patch
which broke rock.

As kinkie said, I reverted it from trunk so I could verify that the
other later patches going through on their way to 3.2 branch were
actually working.

I'm hoping it can be figured out an fixed before 3.2.1 release, but both
Kinkie and myself have attempted to fgure it out and got lost in the code.

Amos
Received on Sun Aug 05 2012 - 11:00:36 MDT