Re: /bzr/squid3/trunk/ r12247: Revert r12231 - seems to break SMP cache

From: Kinkie <gkinkie_at_gmail.com>
Date: Sat, 4 Aug 2012 09:25:36 +0200

Resending, sending from iPhone causes rejection due to HTML format :(
Sorry if it's a duplicate

Hi Alex,
  That patch was causing failures in unit tests for Rock. I tried (and
failed) to
understand its deeper consequences, so it was reversed to try and meet the
release targets. Since it causes obvious failures at build, I hope it'll be
easy for you as original author to understand if the issue is the patch or
whether it trips a problem elsewhere.

   Kinkie

On Fri, Aug 3, 2012 at 10:59 PM, Alex Rousskov
<rousskov_at_measurement-factory.com> wrote:
> On 08/01/2012 05:54 AM, Amos Jeffries wrote:
>> ------------------------------------------------------------
>> revno: 12247
>> committer: Amos Jeffries <squid3_at_treenet.co.nz>
>> branch nick: trunk
>> timestamp: Wed 2012-08-01 23:54:23 +1200
>> message:
>> Revert r12231 - seems to break SMP cache
>> modified:
>> src/store_dir.cc
>
> Is there a bug report or a mailing list posting related to this
> reversal? The r12231 change was fixing a bug. It is possible that the
> fix exposed other bugs, of course, but it is difficult for me to fix
> those if I do not know what they are. If feels that such a drastic
> action as a reversal deserves at least a little bit more documentation.
>
>
> Thank you,
>
> Alex.
>

-- 
    /kinkie
Received on Sat Aug 04 2012 - 07:25:44 MDT

This archive was generated by hypermail 2.2.0 : Sat Aug 04 2012 - 12:00:04 MDT