Re: [PATCH] DNS coding style update

On 2/01/2012 9:31 p.m., Kinkie wrote:
> On Sun, Jan 1, 2012 at 10:37 PM, Amos Jeffries wrote:
>> This is part 1 of some SourceLayout changes for the DNS code.
>>
>> - removes "dnsserver" terminology from all the Squid internals and
>> ./configure docs. Replacing it with "helper" to avoid confusion.
>>
>> - updates the automake conditional to ENABLE_DNSHELPER and code define to
>> USE_DNSHELPER inline with coding guidelines.
>>
>> - shuffles the DNS API definitions to their own header, SquidDns.h, and
>> de-duplicates the init/shutdown API calls to remove some #if
> I like the idea. Patch looks ok to me except that I don't fully
> understand the result of the condition removal in src/snmp_core.cc .
> If it is to return some never-incremented counters when snmp querying
> then it's a +1 from me.

No change to the counters. This is making one API function name used for
both cases and defined by whichever of the dns.cc or dns_internal.cc is
included in the build.

Thanks, I should have straight erased it instead of commenting. That is
fixed now.

Amos
Received on Mon Jan 02 2012 - 11:49:40 MST