Re: [PATCH] Bug 1488: squid_status ACL

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Sun, 06 Nov 2011 11:50:45 +1300

On 5/08/2011 2:36 a.m., Amos Jeffries wrote:
> This updates and completes the work started by Gonzalo Arana in
> creating an ACL to match the TCP_HIT, TCP_MISS, etc internal status of
> request handling.
>
> Requests can change their status over the course of a transaction.
> Particularly around retries and revalidations. This ACL seeks to match
> the current state as of the point of testing. The most reliable place
> is of course in the logging ACL tests after any state changes have
> stopped. Although any point after parsing may match on a relevant status.
>
> To support this the squid status enum and supporting functionality is
> also moved into its own file.
>
>
> NOTES:
> At this point I'm not sure the main code is updating the status
> correctly at all points it should change. Deferred that large audit task.
>
> There is also some questions about the states currently described vs
> the ones that exist in Squid. ie should the enum be extended to a
> larger set with the full state permutations, or split into a bitmap
> that can support match on a subgroups of states (ie all HIT, all REFRESH)
>
>
> Amos

If there are no objections I'll freshen and commit this patch later today.

Amos
Received on Sat Nov 05 2011 - 22:50:50 MDT

This archive was generated by hypermail 2.2.0 : Sun Nov 06 2011 - 12:00:06 MST