Re: [PATCH] Making Mem::Init() re-entrant.

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Wed, 22 Jun 2011 17:47:53 +1200

On 22/06/11 00:47, Amos Jeffries wrote:
> Moving the cache_peer pool to the peer init area has brought to light
> the problem of this pool init function not being safe for repeated
> calls. (bug 3245)
>
> We had some discussion when the opposite of this came up about strings.
>
> Since we have not really settled on whether to make MemPools an
> on-first-demand system I think its time to make some kind of TODO plan now.
>
>
> Do we want to eventually make memory initialization happen on first use?
> In which case I commit this patch now as one small step towards that.
>
>
> Or do we want to set an absolute init order and fail loudly if
> components are initialized in the wrong order?
> In which case I revert the peerSelectInit() changes.
>

Oh well. Still nothing finalized overall. But enough of a consensus to
cover this patch change. Applied.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.12
   Beta testers wanted for 3.2.0.9 and 3.1.12.3
Received on Wed Jun 22 2011 - 05:47:59 MDT

This archive was generated by hypermail 2.2.0 : Wed Jun 22 2011 - 12:00:05 MDT