Re: [PATCH] protocol_t upgrade

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Tue, 01 Mar 2011 14:50:28 +1300

 On Mon, 28 Feb 2011 18:23:51 -0700, Alex Rousskov wrote:
> On 02/28/2011 04:44 PM, Amos Jeffries wrote:
>> In the final URL and protocol design we have AnyP::ProtocolType
>> which
>> enumerates the registered protocols accepted in URLs (lower case)
>> and
>> the request protocol field (upper case). Then URLScheme which
>> expands
>> that to allow other protocol names accepted in URLs.
>
> Perhaps this is too abstract to allow a meaningful discussion right
> now,
> but why not simplify and just have one AnyP::Protocol class that
> stores
> the ID and the image of any protocol? Can that cover both URL scheme
> (lowercase) and MIME message first-line (upper case) uses, among
> other
> things?

 I'm build-testing a patch which includes the missing changes to
 URLScheme which does the split nicely without much alteration to
 existing code.
 Will have that for you in a few hours.

 For now there are places using local representations in strings etc of
 the protocol, or using protocol_t where it should be URLScheme. Future
 polish will clear those up correctly once this patch straightens out the
 two. Then we can move on to supporting unknown URL protocols with
 pass-thru.

 Amos
Received on Tue Mar 01 2011 - 01:50:39 MST

This archive was generated by hypermail 2.2.0 : Tue Mar 01 2011 - 12:00:14 MST