On 02/24/2011 03:27 AM, Amos Jeffries wrote:
> I have now committed the trivial const-correctness and signed/unsigned
> fixes required to build trunk on ICC.
>
> There are however some issues which involve logic changes and thus a
> second pair of eyes to audit.
>
> The attached patch alters the DNS lookup behaviour to abort with an
> error in ALL cases where the rfc1035 library generates an error
> (negative result).
>
> I'm not sure there is any noticable effect other than better code. The
> error case *should* in old code be picked up on the initial packet
> construction rather than the repeat packet. This may be incorrect given
> that the packet type is changing between A/AAAA.
>
> Can someone please check over this fixes and verify that I am not
> breaking anything?
What about similar rfc3596BuildA* calls in idnsGrokReply? Do they need
similar checks?
Thank you,
Alex.
Received on Sat Feb 26 2011 - 20:12:58 MST
This archive was generated by hypermail 2.2.0 : Sun Feb 27 2011 - 12:00:06 MST