Re: [PATCH] Compliance: rename Trailers header to Trailer everywhere.

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Tue, 24 Aug 2010 23:43:31 +1200

Alex Rousskov wrote:
> On 08/18/2010 10:09 PM, Alex Rousskov wrote:
>> Compliance: rename Trailers header to Trailer everywhere.
>>
>> RFC 2616 section 13.5.1 has a typo in Trailers header name. The correct
>> name is Trailer. See http://trac.tools.ietf.org/wg/httpbis/trac/ticket/9
>>
>> Co-Advisor test cases: test_case/rfc2616/hopHdr-Trailer-toClt
>> test_case/rfc2616/hopHdr-Trailer-toSrv
>
> It looks like I did not include the patch. Now attached.
>
> Sorry,
>
> Alex.
>

Given that Squid releases have been emitting the wrong header text for
at least 4 years do you not think we should retain recognition of the
incorrect name and upgrade to the correct one?

This might be accomplished by having two texts pointing to HDR_TRAILER
in src/HttpHeader.cc chunk @106:

- {"Trailers", HDR_TRAILERS, ftStr},
+ {"Trailers", HDR_TRAILER, ftStr},
+ {"Trailer", HDR_TRAILER, ftStr},

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.7
   Beta testers wanted for 3.2.0.1
Received on Tue Aug 24 2010 - 11:43:41 MDT

This archive was generated by hypermail 2.2.0 : Tue Aug 24 2010 - 12:00:05 MDT