Re: [3.1] drop split-stack and V6ONLY magics

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Sat, 15 May 2010 22:47:54 +1200

Henrik Nordström wrote:
> lör 2010-05-15 klockan 10:42 +0200 skrev Henrik Nordström:
>
>> But I honestly do not see why we need to configure run test for any of
>> this, other than that we can compile. A Squid compiled with IPv6 support
>> will now run just fine even if the IPv6 stack is not there at runtime,
>> and the only use of IPV6_V6ONLY in 3.1 is to enable mapped mode in case
>> it's not the default. Having run test in configure should be avoided as
>> much as possible as it makes it more or less impossible to
>> cross-compile.
>
> Proof of concept patch attached for dropping the split-stack magics from
> 3.1. Please comment.
>
> Regards
> Henrik
>

Sigh. The dream of 3.1 split-stack has died :)

Looks right for what you intended.

I think we should retain a test for existence of IPV6_V6ONLY though. It
can be a if-compiles and will catch the WindowsXP etc cases.

The .cc/.h changes need some text fixes:
  "caouse trobles" => "cause trouble"
  "Windows Vista" => "Windows Vista and later"

new level-0 debugs() calls also need to use DBG_CRITICAL instead of
magic number so we can find them again easily.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.3
Received on Sat May 15 2010 - 10:48:05 MDT

This archive was generated by hypermail 2.2.0 : Sun May 16 2010 - 12:00:08 MDT