Re: [PATCH] log virgin HTTP request headers

> Tsantilas Christos wrote:
>> Hi all,
>> This patch adds a new format code which allow the user to log HTTP
>> request header or header fields before they are adapted.
>> The existing "http::>h" format code logs HTTP request headers after
>> adaptation.
>> The new format code is the "http::>hv".
>>
>> This is a Measurement Factory project.
>>
>> Regards,
>> Christos
>>
>
> Um, I would think this makes more sense done the other way around.
>
> With the default >h displaying the virgin headers received from the
> client and some other code ( >ha ?) for the adapted headers. Be it
> adaptation or headers_access doing the alteration.

The only objection I have is that the >h is already implemented to log
headers after adaptation for squid3.0 and squid3.1

I did not have in my mind the headers_access, so in the patch the new
format code activated only if the adaptation is active.
Should the http::>hv (or http::>ha) be always active?

>
> Likewise on replies.
>
> Amos
> --
> Please be using
> Current Stable Squid 2.7.STABLE7 or 3.0.STABLE21
> Current Beta Squid 3.1.0.15
>
Received on Thu Jan 14 2010 - 10:49:48 MST