Re: More patches for squid2-HEAD

>
> Responses inline, and a couple more:
>
> http://www.squid-cache.org/bugs/show_bug.cgi?id=2642
> http://www.squid-cache.org/bugs/show_bug.cgi?id=2643
>
>
> On 20/04/2009, at 4:46 PM, Amos Jeffries wrote:
>
>> Mark Nottingham wrote:
>>> Unless I hear otherwise, I'm going to apply the patches attached to
>>> the following bugs:
>>> http://www.squid-cache.org/bugs/show_bug.cgi?id=2631
>>
>> response in bugzilla.
>
> Likewise.
>
>
>>> http://www.squid-cache.org/bugs/show_bug.cgi?id=2632
>>
>> IMO, this should be number of times squid tries _each_ available
>> forwarding method before giving up on it. With a default of
>> something lower, 1 or 2 may be reasonable in most of todays internet.
>>
>> +1 on the configurable idea though.
>
> Sorry, could you explain what you mean by each method? Is it direct
> vs. peer?

Sorry I'm wandering in the vague area between access methods and routing
directions here. What I mean is an aggregate of all that.

At present we have:
 DIRECT via IP #1
 DIRECT via IP #2
 ... repeat for all possible IPs.
 PEER #1
 PERR #2
 REEP # ... 64

Doing each of those within a 1 minute timeout and 10x attempts per route
causes unreasonably long delays and false-failures. A few hacks reduce
this somewhat by dropping the timeout, doing one connect when >1 IPs
found, and only trying one peer per request, using netdb to improve the
peers chances of working, but still hitting the problem.

>
>
>> Definitely relevant to squid-3, if you commit this for 2 before it
>> gets to 3, please just comment "commited to squid-2" and bump target
>> milestone to 3.HEAD
>
> Ack.
>
>
>>> http://www.squid-cache.org/bugs/show_bug.cgi?id=2515
>>
>> Looks good to me. Mind the formatting though.
>
> Yeah. Still can't get the proper version of indent running on OSX, so
> I have to shove it to another box to indent before submission...

Manual works easier and sometimes faster for small patches like this. :)

>
>> Is it relevant to squid-3 parser?
>
> Don't think so; StringToInt64 doesn't look at errno.
>

Great. Was wondering why I could not find it.

Amos
Received on Tue Apr 21 2009 - 02:08:16 MDT