testHeaders and dirs

On 02/19/2009 04:16 AM, Amos Jeffries wrote:
> Alex Rousskov wrote:
>> === added file 'src/common.am'
>>
>> Copied common Makefile.am stuff seen in a few Makefile.ams to a single
>> Makefile "header". This avoids evil code duplication. This file
>> should be
>> included by most Makefile.ams inside src/. Needs more work as some of
>> the
>> copied code is questionable and more code can probably be extracted
>> here. See
>> XXXs.
>>
>> TODO: The .h dependency test script part seems pretty universal, but if
>> many subdirs need to customize it, we may want to put it into a separate
>> Makefile "header".
> Most if not all of the subdirs which contain child subdirs themselves
> for module includes perform some custom magic with the parameters
> passed to the test script.
>
> The subdirs which perform local-only magic are:
> lib/, src/fs/, src/auth/, src/diskio/ and their children.
>
> I think a custom headertests.am is probably needed for the simple
> subdirs which can get away with only a ./*.h scan.
I will move testHeaders stuff to headertests.am or TestHeaders.am, but
let me provide this as a to-do list for the discussion:

    * lib/ -- Not analyzed as I am focusing on src/ for now. The
      solutions we develop for src/ may be propagated one level up if
      needed and possible.
    * src/fs -- The makefile itself is wrong. We should have fs-specific
      makefiles in src/fs/*/. Once that is done, there will be no need
      for special testHeaders code.
    * src/auth -- Same problem as src/fs
    * src/DiskIO -- Similar problem, but worse. There is not even a
      Makefile for src/DiskIO itself as all the build stuff resides in
      src/Makefile.am.

Thank you,

Alex.
Received on Thu Feb 19 2009 - 15:21:56 MST