Re: Lessons learned from string-fix and consequences on StringNg design

From: Kinkie <gkinkie_at_gmail.com>
Date: Tue, 17 Feb 2009 00:26:35 +0100

>> Definately. With a 32-bit signed size it _should_ be large enough for
>> most uses. A debugs when it goes close to or over the signed rollover
>> would be critical IMO. Maybe more, but debugs & assert for now.
> Do not assert(), just use Must(false) or equivalent. No reason to kill
> the proxy if the caller can simply cancel the offending transaction.
> StringNg already uses exceptions for exceptional situations and this is
> no different.

I agree. In fact, I've defined a SBufTooBigException (inheriting
TextException) for the purpose.

-- 
    /kinkie
Received on Mon Feb 16 2009 - 23:26:43 MST

This archive was generated by hypermail 2.2.0 : Tue Feb 17 2009 - 12:00:04 MST