Re: squid_kerb_auth build issues with 3.1.0.1 on FreeBSD

Markus Moeller wrote:
>
> ----- Original Message ----- From: "Amos Jeffries" <squid3_at_treenet.co.nz>
> To: "Markus Moeller" <huaraz_at_moeller.plus.com>
> Cc: <squid-dev_at_squid-cache.org>
> Sent: Monday, November 10, 2008 1:42 PM
> Subject: Re: squid_kerb_auth build issues with 3.1.0.1 on FreeBSD
>
>
>> Markus Moeller wrote:
>>> I will update accordingly
>>>
>>> Regarding the FD_SETSIZE issue I can remove unistd.h if I use squids
>>> getopt implementation and MAXHOSTNAMELEN (instead of sysconf), but I
>>> am not sure about gethostname. I saw you have also a getfullhostname
>>> function which also uses config.h and unistd.h but doesn't show this
>>> conflict.
>>>
>>> Thank you
>>> Markus
>>
>> The issue is only occuring because system headers are included ahead
>> of Squid's config.h include (both in the .cc directly, and generated
>> into autoconf.h).
>>
>> The whole purpose of the config.h file is to make the code portable.
>> It pulls in the needed alternate system headers depending on which are
>> available and the OS. Some trivial and not so trivial function calls
>> are underlaid with emulators. The getfullhostname() in Squid is one
>> such emulator. xgetaddrinfo() is another.
>>
>> It does this based on your own autoconf.h and Squids. After its
>> included that your code can do whatever it likes.
>>
>> I'm minded to just make the changes as part of the import. Is this
>> helper often built without Squid?
>>
>
> If people want to use it with squid 2.x or 3.0 then they may want to
> configure it without squid sources (as I mentioned before the existing
> code in 2.x and 3.0 does not compile on all platforms) or when it isn't
> part of a binary distribution.
>

Thats my aim too. Making it build inside squid or outside as seamless as
possible.
I'll do a bit of testing and come up with a patch for you to check off.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE5 or 3.0.STABLE10
   Current Beta Squid 3.1.0.2