Re: [MERGE] Connection pinning patch

Adrian Chadd wrote:
> Its a 900-odd line patch; granted, a lot of it is boiler plate for
> config parsing and management, but I recall the issues connection
> pinning had when it was introduced and I'd hate to try and be the one
> debugging whatever crazy stuff pops up in 3.1 combined with the
> changes to the workflow connection pinning introduces.

I am saying in my mail that I am not sure that there is not any bug. I
did not test it using production servers, only I used test web servers,
The ntlm authentication is not widely used in the internet, it is not
easy to find a number of ntlm authenticated sites to do a better test.
However I believe that it is in a good state and we need feedback from
production users in order to fix any remaining bug (IF there is any)

>
> I don't pretend to completely understand the implications for ICAP
> either. Is there any documentation for how connection pinning should
> behave with ICAP and friends?

There is not any special issue when ICAP used...

>
> Is there any particular rush to get this in for this release at such a
> late point in the release cycle?
>
> Could we hold off of it until the next release, and just focus on
> getting whats currently in 3.HEAD released and stable?
>

I believe it is an important feature. The ntlm authentication maybe is
not used for internet sites but it is widely used for corporation
internal sites.
Talking with other system administrators, the connection pinning and
chunked encoding are the most important reasons for a system admin to
not choose squid3 as proxy server for his networks. I am system admin
too and for the same reasons my 2-3 production proxy servers are squid2.
I am waiting 3.1 release to upgrade at least one of them :-)

In any case if the connection pinning will not included in squid 3.1 I
can try to maintain a connection pinning patch for squid 3.1 as
workaround/solution for the people need this feature.

Regards,
    Christos

>
>
> Adrian
>
>
> 2008/9/21 Tsantilas Christos <chtsanti_at_users.sourceforge.net>:
>> Hi all,
>>
>> This patch fixes the bug 1632
>> (http://www.squid-cache.org/bugs/show_bug.cgi?id=1632)
>> It is based on the original squid2.5 connection pinning patch developed by
>> Henrik (http://devel.squid-cache.org/projects.html#pinning) and the related
>> squid 2.6 connection pinning code.
>>
>> Although I spend many hours looking on pined connections I am still not
>> absolutely sure that does not have bugs. However the code is very similar
>> with this in squid2.6 (where the pinning code runs for years) and I hope
>> will be easy to fix problems and bugs.
>>
>> Regards,
>> Christos
>>
>
Received on Sun Sep 21 2008 - 17:59:30 MDT