Re: [MERGE] Rework urlAbsolute to be a little more streamlined.

On Tue, 2008-09-02 at 13:44 +1200, Amos Jeffries wrote:

> > There got to be some way to remove this code duplication (and related
> > inconsistencies)!
>
> That duplication and a lot more URL mess is all covered by Bug 1961.
> http://www.squid-cache.org/bugs/show_bug.cgi?id=1961
>
> Since the original request from Benno was for Vary invalidation. I think
> we can sign off on that merge when the last memory tweaks of urlAbsolute
> are there.
>
> But ignore the duplication until URL cleanup is done, which will be easier
> after the string buffer Kinkie is working on now goes in.

I think it would be better if the patch that introduces more duplication
and more inconsistencies would instead remove at least some of them,
especially since nobody is working on the related bug1961. The "leave
things better than you found them" approach often works well, IMO, and
in this particular case, the amount of "extra" clean up work is minor.

However, I am not going to block this particular submission on the
"significantly increases code duplication" grounds.

We should probably add an XXX comment documenting the duplication of
code in urlRelativeToAbsolute.

Thank you,

Alex.
Received on Tue Sep 02 2008 - 03:43:40 MDT