Re: double-socket statistics in comm.c ?

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Sat, 28 Jun 2008 01:51:21 +1200

Henrik Nordstrom wrote:
> On fre, 2008-06-27 at 13:05 +0800, Adrian Chadd wrote:
>> This is from src/comm.c on squid-2.HEAD in commResetFD():
>>
>> statCounter.syscalls.sock.sockets++;
>> fd2 = socket(AF_INET, SOCK_STREAM, 0);
>> statCounter.syscalls.sock.sockets++;
>>
>> Is there a reason for the statistics to be double-incremented?
>
> Not that I can think of.
>

It's been killed in -3 so I'd say no too.

Amos

-- 
Please use Squid 2.7.STABLE3 or 3.0.STABLE7
Received on Fri Jun 27 2008 - 13:51:20 MDT

This archive was generated by hypermail 2.2.0 : Fri Jun 27 2008 - 12:00:07 MDT