Re: X-Vary-Options patch

On lör, 2008-06-07 at 10:43 +0800, Adrian Chadd wrote:
> I think some of their stuff was backed out of Squid-2.7 before
> release.

The Vary invalidation patch was backed out from 2.7 as it's incomplete
and broke things.

But this X-Vary-Options patch never got committed. Thread stops after
your request for him to file a bugzilla entry, and it got lost in the
noise until found again by Mark.

I have concerns about the completeness about this patch, for example if
it handles q values properly. It's not such abig deal on
Accept-Encoding, but can get quite messy if applying this to Accept or
Accept-Language.

For Accept* heaers I think it needs to be extended with an option
instructing caches to parse the Accept* header to a limited degree,
which means the cache needs to know the list of available choices for
the header at the server and their order of priority.

Also, for cookie it needs to be a little more elaborate as most often
one wants to match on cookie names, not their vaule.. and sometimes a
value of a specific cookie.

Regards
Henrik
Received on Sat Jun 07 2008 - 07:20:03 MDT