Re: squid3-ipv6 squid3/src ACLIP.cc,1.8.2.47,1.8.2.48

On ons, 2007-09-26 at 03:54 +0000, Amos Jeffries wrote:

> ! DecodeMask(NULL, &q->mask); // AYJ: is this just initialisation? if so we don't need it.
> ! if (*l_mask && !DecodeMask(l_mask, &q->mask, iptype)) {

It's initialization to a /32 mask.

If the object starts out with a full mask then not needed, but from what
I can tell it starts out with a /0 mask which is not what we want.

Hmm.. yes, can be simplified. Just

   if (!DecodeMask(l_mask, &q->mask, iptype)) {

is sufficient. Cleaning that up, with a comment to remind this feature
of DecodeMask.

Regards
Henrik