Re: cvs commit: squid3/src ftp.cc

On ons, 2007-08-15 at 09:28 +1200, Amos Jeffries wrote:
> >> > > If you have time, it may be better to replace a virtual
> >> > > FtpStateData::haveControlChannel(char*) into a static
> >> > > FtpStateData::HaveControlChannel(FtpStateData*, char*) and let it
> >> check
> >> > > the ftpState pointer itself. This will avoid more code repetition
> >> and
> >> > > may even work faster.
> >> >
> >> > Whats with the uppercasing? the method is not a type. Is this a new
> >> > convention not mentioned in the wiki/devel-faq?
> >>
> >> Hmm.. it should be in the style guide somewhere.
> >
> > http://www.squid-cache.org/Devel/squid-3-style.txt
> >
>
> What I based the following on. Alex posted an upper-cased
> internal-but-public method (NOT data member).

It's a static class function, not an object method, which brings it into
the "Global" naming recommendation.

   static FtpStateData::HaveControlChannel(FtpStateData*, char*)

Regards
Henrik