Re: Default debug stream formatting

From: Henrik Nordstrom <henrik@dont-contact.us>
Date: Thu, 09 Aug 2007 10:06:54 +0200

On tor, 2007-08-09 at 07:44 +1000, Robert Collins wrote:
> On Wed, 2007-08-08 at 08:28 -0600, Alex Rousskov wrote:
> > Hi,
> >
> > Any objections to setting the default formatting flags for the Squid3
> > debugs() stream to "fixed" with a 2-digit precision? It would help to
> > convert cache.log messages like
> >
> > Took 6.6 seconds (3.5e+03 objects/sec).
> >
> > into more readable/usable
> >
> > Took 7.12 seconds (3147.13 objects/sec).
> >
> > without modifying the debugs() statements themselves (which is actually
> > impossible for flags like ios::fixed that do not have a stream
> > manipulator).
> >
> > The patch is quoted below. Any other flags we should set by default?
> >
> > If there are no objections, I will commit the patch.
>
> +1

+1

(automatic on any change which is non-intrusive and makes the code or
output more readable)

Regards
Henrik

Received on Thu Aug 09 2007 - 02:07:09 MDT

This archive was generated by hypermail pre-2.1.9 : Fri Aug 31 2007 - 12:00:05 MDT