Re: cvs commit: squid3/src HttpReply.cc

From: Alex Rousskov <rousskov@dont-contact.us>
Date: Tue, 22 May 2007 11:30:36 -0600

On Tue, 2007-05-22 at 19:14 +0200, Henrik Nordstrom wrote:
> tis 2007-05-22 klockan 10:37 -0600 skrev Alex Rousskov:
>
> > Bug #1967 fix: avoid new strncmp() that silently converts char* buffers into
> > Strings because String length is limited by 64KB and because it is an
> > expensive conversion.
>
> Ugh... C++ magics strikes again. Thanks for finding this. Was a bit
> worried there for a while.

And you should still be worried, unfortunately: I have not fixed the
actual "misapplication of magic" problem, just stopped using strcmp in
one particular piece of code. See bug #1970.

Alex.
Received on Tue May 22 2007 - 11:30:48 MDT

This archive was generated by hypermail pre-2.1.9 : Fri Jun 01 2007 - 12:00:09 MDT